search

emacs-lsp / lsp-metals

lsp-mode :heart: metals
https://emacs-lsp.github.io/lsp-metals
GNU General Public License v3.0
58 stars 34 forks source link

update required scala-mode version: 1.1 -> 0.23 #107

Closed contagnas closed 2 months ago

contagnas commented 3 months ago

scala-mode 1.1 does not exist; 0.23 is the current version.

https://github.com/hvesalai/emacs-scala-mode/blob/master/scala-mode.el#L7

This breaks installing lsp-metals in my setup (use-package with elpaca).

1.1 was set as the dependency in https://github.com/emacs-lsp/lsp-metals/pull/48. I didn't chase why this was set any further than that.

kurnevsky commented 3 months ago

The header just wasn't updated, but the version exists: https://stable.melpa.org/#/scala-mode

You should probably raise an issue in scala-mode repo. But fair enough, Package-Requires takes the version info from the header.

I'm wondering, do we need to have scala-mode as strict dependency now when there is an alternative as scala-ts-mode? @yyoncho wdyt? (pinging you since you suggested it :) ).

kurnevsky commented 2 months ago

I'll merge it for the time being. Thanks.