search

emacs-lsp / lsp-metals

lsp-mode :heart: metals
https://emacs-lsp.github.io/lsp-metals
GNU General Public License v3.0
58 stars 33 forks source link

Move lsp-metals-treeview. #2

Closed kurnevsky closed 4 years ago

kurnevsky commented 4 years ago

@dsyzling want to help fixing checkdoc? :)

dsyzling commented 4 years ago

Yes no problem, I can take a look.

dsyzling commented 4 years ago

I've pushed up a branch - treeview-docs to my fork - wasn't sure about using this one. Do I need to create a pull request from that branch - or is there an easier way?

dsyzling commented 4 years ago

Are you copying over icons/metals from lsp-treemacs as well?

kurnevsky commented 4 years ago

I've pushed up a branch - treeview-docs to my fork - wasn't sure about using this one. Do I need to create a pull request from that branch - or is there an easier way?

You can push in this branch, I was going to merge it only after CI succeeds.

Are you copying over icons/metals from lsp-treemacs as well?

Forgot about them, need to move as well.

dsyzling commented 4 years ago

I'm not sure I've done that correctly - I've fetched the /pull/2/head branch into my fork and then pushed up as the 'treeview' branch in my fork - I don't think that's correct though.

kurnevsky commented 4 years ago

Pushed it myself. Thanks for the help!