emacs-lsp / lsp-metals

lsp-mode :heart: metals
https://emacs-lsp.github.io/lsp-metals
GNU General Public License v3.0
58 stars 34 forks source link

Symbol’s function definition is void: treemacs-define-doubleclick-action #38

Closed marcsaegesser closed 3 years ago

marcsaegesser commented 3 years ago

Describe the bug After updating to the latest versions of package I get the following error when I start Emacs or try to open a Scala project. Symbol’s function definition is void: treemacs-define-doubleclick-action

I think the problem was caused by a recent change to treemacs. As a hack I added (require 'treemacs-mouse-interface) to lsp-metals-treeview.el and the problem went away.

To Reproduce Use the most recent packages from elpa and start emacs.

Expected behavior Start without errors.

gagbo commented 3 years ago

I just added (autoload 'treemacs-define-doubleclick-action "treemacs-mouse-interface" nil nil) to my init.el and it solved it as well, as far as I understand.

I went for this because :

marcsaegesser commented 3 years ago

@gagbo Thanks for that. Now I've learned something new today!

kurnevsky commented 3 years ago

Looks like it should be reported to treemacs. We don't use this function directly, so probably treemacs-extensions should require treemacs-mouse-interface.

kurnevsky commented 3 years ago

Caused by https://github.com/Alexander-Miller/treemacs/issues/464

Alexander-Miller commented 3 years ago

treemacs-extensions should require treemacs-mouse-interface.

That's been pushed now.

marcsaegesser commented 3 years ago

Things seem good now. Thank you, all.

wyuenho commented 7 months ago

It looks like this issue is back

gagbo commented 7 months ago

It shouldn't be the case. The root cause of this issue was a missing autoload cookie, and it’s been fixed in treemacs 3 years ago

wyuenho commented 7 months ago

Looks like Alexander-Miller/treemacs@2f77c9828116767f1be5cfdd3f82d2bed7ceea93 has broken it again, tho only during native compilation

Alexander-Miller commented 7 months ago

So anyway, treemacs has a new feature that lets you define double-click actions for your extensions now :neutral_face:.