search

emacs-lsp / lsp-metals

lsp-mode :heart: metals
https://emacs-lsp.github.io/lsp-metals
GNU General Public License v3.0
58 stars 34 forks source link

Company completion not working #39

Closed ashkan-leo closed 2 years ago

ashkan-leo commented 3 years ago

Describe the bug I am using Doom Emacs, and company completion does not work for me when editing Scala code. Other functionalities like goto definition, type inference, etc. seem to work fine.

To Reproduce This happens with multiple projects. I have attached a toy project too. awesome-zio-bak.zip

Expected behavior The company completion should work in Scala projects.

Screenshots If applicable, add screenshots to help explain your problem.

Logs Please include the debug stack trace (if there is an error) and the content of Messages buffer with lsp-print-io set to t in case the bug is related to client->server communication.

jackcviers commented 3 years ago

More interesting news on this bug:

Company completion works perfectly if the project has scalaVersion:="2.13.3" or below, but with 2.13.5 it fails, even though lsp-metals-doctor-run shows everything should work just fine.

Top-level compeltions of object/class names are fine. It is method level completion that fails. This is, obviously, with metals Tungsten.

Did something change in the protocol between 2.13.5 and 2.13.3?

Also, I have tried with both company-lsp and without. company-lsp is deprecated in the latest lsp-mode, and you can just use company.

kurnevsky commented 2 years ago

@ashkan-leo @jackcviers is it still an issue? Just checked attached project and completion works fine for me there.

jackcviers commented 2 years ago

No. Seems to be fixed on 2.13.5/6.

On Tue, Aug 10, 2021 at 8:30 AM Evgeny Kurnevsky @.***> wrote:

@ashkan-leo https://github.com/ashkan-leo @jackcviers https://github.com/jackcviers is it still an issue? Just checked attached project and completion works fine for me there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/emacs-lsp/lsp-metals/issues/39#issuecomment-896030672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBHFE2H4MU7UVFRXVH5YTT4ESXZANCNFSM4V6PKMWQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .