Support launch.json and debug attach

emacs-lsp / lsp-metals

lsp-mode :heart: metals

https://emacs-lsp.github.io/lsp-metals

GNU General Public License v3.0

58 stars 34 forks source link

Closed yyoncho closed 3 years ago

yyoncho commented 3 years ago

Fixes #41 Fixes #49

gagbo commented 3 years ago

Is there any blocker on this ? The CI failed on a (hopefully) totally unrelated error when Cask was fetching deps

Some dependencies were not available: treemacs, ht, f, dap-mode, lsp-treemacs, lsp-mode, scala-mode, scala-mode

yyoncho commented 3 years ago

I will merge it as it is. If @kurnevsky has comments they will be addressed separately

gagbo commented 3 years ago

Oh, I forgot to add a comment, apparently @tomahna has been testing the PR and a :type key is missing in the dap-debug-template call somehow.

yyoncho commented 3 years ago

@gagbo yes, it is missing on line 564.