search

emacs-lsp / lsp-metals

lsp-mode :heart: metals
https://emacs-lsp.github.io/lsp-metals
GNU General Public License v3.0
58 stars 34 forks source link

tests(Makefile): Update eask's commands #82

Closed jcs090218 closed 1 year ago

jcs090218 commented 1 year ago

This fixes CI.

kurnevsky commented 1 year ago

Thanks. It seems it didn't fix the CI. Is there anything left to do? :)

jcs090218 commented 1 year ago

The error is:

lsp-metals-treeview.el:338:1:Error: Wrong number of arguments: (1 . 1), 0

Due to #81. It's an issue from upstream, https://github.com/Alexander-Miller/treemacs/issues/982. Nothing I can do for the issue. (Not in this PR)

Hence, nothing left to do.

kurnevsky commented 1 year ago

Ah, ok, thanks. I got confused by a lot of Can't find library errors :)

jcs090218 commented 1 year ago

Ah, ok, thanks. I got confused by a lot of Can't find library errors :)

Ah, yes. It's discussed in https://github.com/emacs-eask/cli/issues/11. I guess it's a known issue from Eask. Sorry for the confusion!

kurnevsky commented 1 year ago

It doesn't make things worse, so I'll merge this. Thanks.