Poor contrast in treeview in light mode

emacs-lsp / lsp-metals

lsp-mode :heart: metals

https://emacs-lsp.github.io/lsp-metals

GNU General Public License v3.0

58 stars 34 forks source link

Poor contrast in treeview in light mode #96

Closed cpitclaudel closed 9 months ago

cpitclaudel commented 1 year ago

Describe the bug With frame-background-mode set to light and a light theme (e.g. tango), metals uses white icons on white background in lsp-metals-treeview, even with lsp-metals-treeview-theme set to Metals-dark.

Screenshots

Screenshot from 2023-06-11 12-51-57

Screenshot from 2023-06-11 12-53-00

kurnevsky commented 9 months ago

Fixed by https://github.com/emacs-lsp/lsp-metals/commit/c1d90f64abdfd1af52f041ed420ab772dc8abc73