emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.73k stars 863 forks source link

lsp-unconfig-buffer is ran even when there is still one active client, therefore no code completions #3347

Open daanturo opened 2 years ago

daanturo commented 2 years ago

Thank you for the bug report

Bug description

lsp-unconfig-buffer is ran even when there is still one active client

it disables lsp-completion-mode.

Steps to reproduce

  1. Install typescript-language-server but don't install angular server
  2. Open an .ts file in an sample angular project (ng new --skip-install --defaults my-test-lsp)

Expected behavior

lsp-completion-mode and lsp-managed-mode are active in those buffers.

Observed: After step 2:

LSP :: angular-ls has exited (exited abnormally with code 1)
Server angular-ls:89021/starting exited with status exit(check corresponding stderr buffer for details). Do you want to restart it? (y or n) n

Then many features are disabled such as code completions, breadcrumb while ts-ls is perfectly capable of providing those functionalities.

Which Language Server did you use?

typescript-language-server angular-language-server (lsp-mode tried to connect but failed because it wasn't installed)

OS

Linux

Error callstack

No response

Anything else?

No response

yyoncho commented 2 years ago

As a workaround, you may disable the angular ls using lsp-disabled-clients.