Volar language server does not start for fresh Vue project

[ItsHoff]

Thank you for the bug report

• [X] I am using the latest version of lsp-mode related packages.
• [X] I checked FAQ and Troubleshooting sections
• [X] You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

Volar language server does not start for a fresh Vue project.

Steps to reproduce

1. Create a fresh Vue project npm init vue@latest
2. Open a Vue file (for example, src/App.vue)

Expected behavior

Volar server is started, or Volar offered in the list of servers that can be installed.

Which Language Server did you use?

lsp-volar

OS

Windows

Error callstack

N/A

Anything else?

It seems that lsp-volar--activate-p expects to find lsp-workspace-root (https://github.com/emacs-lsp/lsp-mode/blob/358b5df8df10b4837193af78c2e72df2c381b1fa/clients/lsp-volar.el#L118-L128), which in this case is nil. If the project root is added using lsp-workspace-folders-add then Volar starts as expected.

[yyoncho]

That is a known limitation, we should restructure lsp-mode to pick project root before checking if there is server matching the current file.

[dirodriguezm]

@yyoncho Is there a workaround for this limitation ?

[yyoncho]

@dirodriguezm the workaround is in the report description - use lsp-workspace-folders-add before opening the project