Closed josteink closed 1 year ago
I believe @razzmatazz was investigating that.
I have this too, any progress or news about this? :)
sorry, i'm busy with my $dayjob
though i should be able to take a look this weekend
Just FYI, I've tested with eglot
, and that does not experience this error.
That might be worth comparing to, codewise?
@josteink if you can do M-x trace-function RET make-process
it will show up the difference.
Ahem.
That's quite a difference.
eglot:
======================================================================
1 -> (make-process :name "EGLOT (SOFO/(csharp-ts-mode csharp-mode))" :command ("/home/jostein/bin/omnisharp" "-lsp") :connection-type pipe :coding utf-8-emacs-unix :noquery t :stderr #<buffer *EGLOT (SOFO/(csharp-ts-mode csharp-mode)) stderr*> :file-handler t)
1 <- make-process: #<process EGLOT (SOFO/(csharp-ts-mode csharp-mode))>
======================================================================
lsp-mode:
======================================================================
1 -> (make-process :name "omnisharp" :connection-type pipe :buffer "*omnisharp*" :coding no-conversion :command ("/home/jostein/.emacs.d/.cache/lsp/omnisharp-roslyn/latest/omnisharp-roslyn.zip" #1="-lsp") :filter #[514 "\300\306\303\242!\203\f\0\202\0\303\242P\240\210\307\306\300\242!\204\302\242\204u\0\310\300\242\307\311\312$\266\203\211\203h\0\302\313\314\315\316\317\300\242\320\300\242\307\311\312$\266\203\206I\0\321\322!#\323\"\"!\240\210\304\324\240\210\303\307\240\210\300\317\300\242\325\\\"\240\266\202\0\303\300\242\240\210\300\307\240\266\202\0\326\300\242!\302\242\304\242Z\211W\203\225\0\317\300\242\324#\300\317\300\242\"\240\210\202\233\0\300\242\300\307\240\210\326!\301\301\242B\240\210\304\211\242\\\240\210Y\203\3271\330\331\312\"r\211q\210\332\333\"\216\334\335\301\242\303\307\240\210\302\307\240\210\304\307\240\210\301\307\240\210\237\"\210\336ed\337#\210eb\210\340\341*\203\356\0\342\202\357\0\343\344\307\345\307&*B\211\262\2620\266\202\0\346\347\303\242 P#\266\266\202\0\350\332\351\305\"\237\"\207" [(nil) (nil) (nil) (nil) (0) #2=#s(lsp--workspace nil nil nil "/home/jostein/build/SOFO" #s(lsp--client nil nil (:connect #[1285 "\303\304!\203
\0\305\306\300!\"\207\306\300!\307!\310!\311\312\"\313 \314\315\316\317\320\311\321 \"\322\323\324\f\325\326\327\330\331&\332\333\"\210\332\334!\333\"\210r\335!q\210\336 *\210\211B\266\202)\207" [#[0 "\301\302 \303D\205\0\304\305!D\"\207" [lsp-csharp-solution-file append lsp-csharp--language-server-path #1# "-s" expand-file-name] 5] process-environment default-directory functionp json-rpc-connection lsp-json-rpc-connection lsp-resolve-final-function generate-new-buffer-name lsp--compute-process-environment format "*%s::stderr*" lsp--default-directory-for-connection make-process :name :connection-type pipe :buffer "*%s*" :coding no-conversion :command :filter :sentinel :stderr :noquery t set-process-query-on-exit-flag nil get-buffer-process get-buffer special-mode] 27 "\n\n(fn FILTER SENTINEL NAME ENVIRONMENT-FN WORKSPACE)"] :test? #[0 "\300 \211\205 \0\301!\207" [lsp-csharp--language-server-path f-exists?] 3]) nil nil #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ("o#/projectadded" ignore "o#/projectchanged" ignore "o#/projectremoved" ignore "o#/packagerestorestarted" ignore "o#/msbuildprojectdiagnostics" ignore "o#/packagerestorefinished" ignore "o#/unresolveddependencies" ignore "o#/error" lsp-csharp--handle-os-error "o#/testmessage" lsp-csharp--handle-os-testmessage "o#/testcompleted" lsp-csharp--handle-os-testcompleted "o#/projectconfiguration" ignore "o#/projectdiagnosticstatus" ignore)) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) #s(hash-table size 65 test eql rehash-size 1.5 rehash-threshold 0.8125 data ()) nil #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ("omnisharp/client/findReferences" lsp-csharp--action-client-find-references)) (csharp-mode csharp-tree-sitter-mode csharp-ts-mode) nil -1 omnisharp nil nil nil nil nil nil nil nil nil nil nil nil nil #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) lsp-csharp--omnisharp-download-server nil nil nil) nil nil nil (#<buffer Startup.cs>) nil nil nil starting #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) nil 0 nil nil #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ()) #s(hash-table size 65 test equal rehash-size 1.5 rehash-threshold 0.8125 data ())) s-blank? nil "
\n
\n" string-match t lsp--get-body-length mapcar lsp--parse-header split-string substring-no-properties "Content-Length" error "Unable to find Content-Length header." "
\n" 0 4 string-bytes (error) generate-new-buffer " *temp*" make-closure #[0 "\301\300!\205 \0\302\300!\207" [V0 buffer-name kill-buffer] 2] apply insert decode-coding-region utf-8 json-parse-buffer :object-type plist hash-table :null-object :false-object lsp-warn "Failed to parse the following chunk:\n'''\n%s\n'''\nwith message %s" mapc #[257 "\301\300\"\207" [V0 lsp--parser-on-message] 4 "\n\n(fn MSG)"] lsp-use-plists] 19 "\n\n(fn PROC INPUT)"] :sentinel #[128 "\302\301\303\300\"\"\207" [(#2#) lsp--process-sentinel apply append] 6 "\n\n(fn &rest ARGS2)"] :stderr "*omnisharp::stderr*" :noquery t)
1 <- make-process: !non-local\ exit!
======================================================================
lsp-mode is calling "/home/jostein/.emacs.d/.cache/lsp/omnisharp-roslyn/latest/omnisharp-roslyn.zip" which is incorrect...
I will have to agree about that. Not sure if that is a regression in the lsp-mode code-base or if it is a change in Emacs core functions which is causing this change on the lsp-mode end.
It is regression in lsp-cshart.el, I will fix it.
PR at #3857
Thanks!
Thank you for the bug report
lsp-mode
related packages.M-x lsp-start-plain
Bug description
When building emacs from source and using the git release branch for emacs-29, omnisharp fails to start.
Other language-servers however works fine for me (
lsp-csharp
withcsharp-ls
,lsp-json
,lsp-typescript
, etc).This error is very specificly for Omnisharp Roslyn, but it may point to to some fundamental changes in Emacs which could be troublesome for other servers and/or emacs-packages as well.
Steps to reproduce
Prerequisites:
To reproduce:
Expected behavior
lsp-mode to acitvate the omnisharp-roslyn language server.
Which Language Server did you use?
lsp-csharp, with omnisharp-roslyn
OS
Linux
Error callstack
Anything else?
Tested on both Ubuntu 22.04 and 22.10. This error seems to be related to very recent changes to Emacs.
If using
csharp-ls
as a language server I don't seem to be getting this error.I see this issue involves many different components, and I'm honestly not sure which party should be responsible for fixing this:
CC: @filipw @monnier