search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.75k stars 872 forks source link

Support crystalline for Crystal #4003

Open restitux opened 1 year ago

restitux commented 1 year ago

It seems crystalline has replaced scry. The scry repo README now links to crystalline (see https://github.com/elbywan/crystalline).

It did some basic testing by renaming the crystalline binary to scry. Most basic features I tried to use seemed to work correctly.

yyoncho commented 1 year ago

willing to provide a PR?

restitux commented 1 year ago

Sure, would you suggest dropping support for scry or supporting both?

restitux commented 1 year ago

PR assuming we want to drop scry: https://github.com/emacs-lsp/lsp-mode/pull/4007

xendk commented 1 year ago

I'll second this.

The current workaround is (setq lsp-clients-crystal-executable '("crystalline" "--stdio")), which works, but would be nice if it just worked out of the box.