search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.8k stars 892 forks source link

Revert "lsp-csharp: add a test to check if dotnet tool csharp-ls is actually installed" #4368

Closed Hi-Angel closed 8 months ago

Hi-Angel commented 8 months ago

This commit broke detection of csharp-ls. I am not sure what was the purpose of the change. The function it added says it checks whether csharp-ls is present in the system, however the function lsp-csharp--cls-make-launch-cmd always did the same and better. So why have this additional check is not at all clear.

The function was assuming that a dotnet tool list -g should return if csharp-ls is installed, however for me its output is just empty:

λ dotnet tool list -g
Package Id      Version      Commands
-------------------------------------

Let's revert this commit.

Fixes: https://github.com/emacs-lsp/lsp-mode/issues/4365 CC: @razzmatazz the original commit author

razzmatazz commented 8 months ago

Thank you! I do not remember why it was added in the first place–good riddance. Can confirm the change works for me.