Use tramp's remote shell

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol

https://emacs-lsp.github.io/lsp-mode

GNU General Public License v3.0

4.72k stars 861 forks source link

Use tramp's remote shell #4384

Closed vljosa-vivodyne closed 1 month ago

vljosa-vivodyne commented 3 months ago

Use the tramp-remote-shell property on the current tramp connection instead of assuming that it's the same as the shell on the local machine.

The stty hack comes from this eglot commit: https://github.com/emacs-mirror/emacs/commit/2076d345655206254f6749cf710c150dfec313dd

Resolves #4371

yyoncho commented 3 months ago

The CI is red: https://github.com/emacs-lsp/lsp-mode/actions/runs/8353897412/job/22866353094?pr=4384#step:12:631 . You should use the corresponding declare-functions to make it pass.

jcs090218 commented 3 months ago

Friendly ping. :)

vljosa-vivodyne commented 1 month ago

Thanks for the ping @jcs090218. I'm going to close this pull request because I never managed to make lsp-mode usable over tramp. I think this change is sensible but don't feel comfortable making it when I can't QC it end to end.