search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.76k stars 879 forks source link

Introduce YANG LSP support #4390

Closed esmasth closed 6 months ago

esmasth commented 6 months ago

This addresses emacs-lsp/lsp-mode#4355

jcs090218 commented 6 months ago

There is a compile error:

In toplevel form:
clients/lsp-yang.el:56:2: Error: assignment to free variable ‘lsp-json-schemas’
..........................Test lsp-byte-compilation-test backtrace:

Test lsp-byte-compilation-test condition:

    (ert-test-failed
     ((should
       (byte-compile-file library))
      :form
      (byte-compile-file "/home/runner/work/lsp-mode/lsp-mode/clients/lsp-yang.el")
      :value nil))

Can you update our CHANGELOG.org too? :)

esmasth commented 6 months ago

I'll fix both in the next patch, thanks.

esmasth commented 6 months ago

@jcs090218 request your rereview here

esmasth commented 6 months ago

Thanks @jcs090218. Could you please guide me on how to resolve the failing checks? I don't know where to start.

jcs090218 commented 6 months ago

Thanks @jcs090218. Could you please guide me on how to resolve the failing checks? I don't know where to start.

Don't worry about the failing tests. It's irrelevant to this PR.

esmasth commented 6 months ago

Thanks a lot @jcs090218. I have resolved the review comments hopefully, and also fixed the settings.json match pattern as a separate commit. OK to merge? I don't have permissions.

jcs090218 commented 6 months ago

Thank you for your contribution!