emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.8k stars 892 forks source link

Unwanted Automatic Start of Common Lisp's LSP #4391

Closed linuxmetel closed 8 months ago

linuxmetel commented 8 months ago

Thank you for the bug report

Bug description

Although I do not want use LSP in lisp-mode (I am a slime user) and I have not made a such setting, LSP (alive) automatically starts each time I open a .lisp file after this commit.

lsp-lisp.el directly adds LSP to lisp-mode-hook in the auto-load process. I looked at some other lsp-clients like lsp-clangd.el and lsp-pyls.el, and I found they not edit or add something to hooks. Thus, I believe that it is a strange behavior. https://github.com/emacs-lsp/lsp-mode/blob/193c714c1d74afeee154b255fbe85025cc4ee690/clients/lsp-lisp.el#L48-L64

Steps to reproduce

Open any .lisp file.

Expected behavior

not edit hooks

Which Language Server did you use?

(omit)

OS

Linux

Error callstack

No response

Anything else?

This behavior is very annoying me.

linuxmetel commented 8 months ago

@jcs090218 lsp-lisp-alive-start-ls seems to do something required by using alive, so I think just removing them may break it. Could you explain your intention or fix this strange behavior?

jcs090218 commented 8 months ago

@jcs090218 lsp-lisp-alive-start-ls seems to do something required by using alive, so I think just removing them may break it. Could you explain your intention or fix this strange behavior?

Sorry about this. The intention was to start the language server when the file was opened. 🤔