rust types displayed in minibuffer are truncated

Ngoguey42 commented 2 months ago

Thank you for the bug report

[X] I am using the latest version of lsp-mode related packages.
[X] I checked FAQ and Troubleshooting sections
[X] You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

Putting the cursor on a rust variable shows the type in the minibuffer:

Recently this stopped working correctly for some types:

When I run lsp-describe-thing-at-point on this problematic type I see 2 lines:

My understanding is that only the first line is shown in the minibuffer.

Steps to reproduce

cargo init --name main to create a dummy project
open main.rs with emacs
answer i to the prompt that offers to import the project root
Add an let i = 0; line in the code.
Put the cursor on i and witness the problem in the minibuffer

Expected behavior

The type of the variable should be shown

Which Language Server did you use?

emacs

GNU Emacs 29.3

RA

rust-analyzer 0.3.1932-standalone (47a901b9b 2024-04-21)

lsp-mode

commit f2b9ab5e2b64a996ca093206a2adf54c578febc2 (HEAD, origin/master, origin/HEAD)
Author: Muir Manders <muir@mnd.rs>
Date:   Sun Apr 21 20:34:08 2024 -0700
    Co-authored-by: Muir Manders <muirdm@fb.com>

OS

MacOS

Error callstack

No response

Anything else?

No response

Ngoguey42 commented 2 months ago

I was able to mitigate this problem using (setq lsp-eldoc-render-all t)

gagbo commented 1 month ago

It’s probably part of this PR/discussion https://github.com/emacs-lsp/lsp-mode/pull/1740, which iirc didn’t get merged because the parsing/matching was too brittle and dependant on RA unspecified implementations that could change version to version

emacs-lsp / lsp-mode