search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.72k stars 860 forks source link

Add go-to definition in metadata #4441

Closed cheerio-pixel closed 1 month ago

cheerio-pixel commented 2 months ago

Reviving the work of razzmat, I have reworked his pull request to support this feature.

jcs090218 commented 1 month ago

@razzmatazz WDYT? 🤔

razzmatazz commented 1 month ago

@razzmatazz WDYT? 🤔

Reviewed, thank you! Approved 👍🏻 , with a suggestion to rename omnisharp-related fns to have omnisharp in the name

jcs090218 commented 1 month ago

@cheerio-pixel Friendly ping! :)

cheerio-pixel commented 1 month ago

@cheerio-pixel Friendly ping! :)

Sorry, completly forgot everything about this. Thanks for the ping.

cheerio-pixel commented 1 month ago

@jcs090218 Finished applying the suggestions. Sorry for messing up with the historial. I didn't realize that rebase modifies the authoring information.

jcs090218 commented 1 month ago

Can you fix these compile warnings? Thanks! :)

In lsp-csharp--omnisharp-metadata-uri-handler:
lsp-csharp.el:358:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In lsp-csharp--omnisharp-uri->path-fn:
lsp-csharp.el:394:2: Warning: docstring wider than 80 characters
cheerio-pixel commented 1 month ago

@jcs090218 Anything more?