emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.72k stars 860 forks source link

Zig's ZLS download URLs have changed #4445

Open nordlow opened 2 months ago

nordlow commented 2 months ago

Thank you for the bug report

Bug description

lsp-zig.el needs to be adjusted to download the now uncompressed binary from https://github.com/zigtools/zls/wiki/Installation#latest-nightly.

Steps to reproduce

Open a .zig file and the error occurrs.

Expected behavior

The output in Message become

LSP :: Download zls started. LSP :: Starting to download https://github.com/zigtools/zls/releases/latest/download/zls-x86_64-linux.tar.gz to ~/.emacs.d/.cache/lsp/zig/temp.tar.gz... Contacting host: github.com:443 Wrote ~/.emacs.d/.cache/lsp/zig/temp.tar.gz LSP :: Finished downloading ~/.emacs.d/.cache/lsp/zig/temp.tar.gz... LSP :: Decompressing ~/.emacs.d/.cache/lsp/zig/temp.tar.gz... tar: This does not look like a tar archive

gzip: stdin: not in gzip format tar: Child returned status 1 tar: Error is not recoverable: exiting now LSP :: Decompressed ~/.emacs.d/.cache/lsp/zig/temp... LSP :: Server zls downloaded, auto-starting in 1 buffers. Quit [2 times] Displaying messages... Mark set

Which Language Server did you use?

I used lsp-zig.

OS

Linux

Error callstack

No response

Anything else?

No response

jcs090218 commented 2 months ago

Opened the issue in https://github.com/zigtools/zls/issues/1879.