search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.76k stars 879 forks source link

Switch tool detection for lsp-unzip (#3022) #4472

Open Horrih opened 3 months ago

Horrih commented 3 months ago

It caused issues on windows if unzip was found on the PATH, because it fell back to the bash command + unzip.

Changing in order of detection fixes the issue.

yyoncho commented 3 months ago

This will force powershell on linux which IIRC was causing trouble in the past. Can you add additional condition (if on windows and if powershell there - use it)

Horrih commented 3 months ago

Just pushed a new version, is this what you had in mind ? Just checked it on both my systems, it seems to work fine.

Btw, thanks a lot for your selfless work on lsp-mode. Lsp-mode is the sole reason I came back to emacs in 2019 years after I gave up on the tags system.

yyoncho commented 3 months ago

((executable-find "powershell") lsp-ext-pwsh-script

can you keep that too in the end?

Horrih commented 3 months ago

Sure, is that better ?

I rebased onto master + squashed the previous commits