lsp-roslyn triggers warning on 30 RC

[gagbo]

Thank you for the bug report

• [X] I am using the latest version of lsp-mode related packages.
• [X] I checked FAQ and Troubleshooting sections
• [x] You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Bug description

When I start lsp-mode in doom, I get

~/.config/emacs/.local/straight/build-30.0.91/lsp-mode/lsp-roslyn.el: Warning:
    ‘make-network-process´ called without required keyword argument :service

in a *Compile-Log* buffer

Steps to reproduce

Pretty sure that to repro this, you just need to:

• go to lsp-roslyn.el
• call emacs-lisp-native-compile

Expected behavior

No warning

Which Language Server did you use?

None.

OS

Linux

Error callstack

`*Compile-Log*`

Compiling file /Users/gagbo/.config/emacs/.local/straight/repos/lsp-mode/clients/lsp-roslyn.el at Fri Oct 25 08:53:00 2024
Entering directory ‘/Users/gagbo/.config/emacs/.local/straight/repos/lsp-mode/clients/’
lsp-roslyn.el:62:19: Warning: in defcustom for ‘lsp-roslyn-server-log-level’:
    irregular type ‘:tag’
lsp-roslyn.el:127:10: Warning: ‘make-network-process´ called without required
    keyword argument :service

Anything else?

Not sure how relevant the bug is, because of the Emacs version, but given I’m on 0.91, I thought it would be nice to warn [sic] about this.

[kiennq]

The :service path in the make_network-process can probably be omitted. It connects to a named pipe instead of a server with a port so specifying service here is not really necessary.