Deal with 'workspace/diagnostic/refresh' message

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol

https://emacs-lsp.github.io/lsp-mode

GNU General Public License v3.0

4.81k stars 890 forks source link

Deal with 'workspace/diagnostic/refresh' message #4600

Closed alanz closed 2 weeks ago

alanz commented 3 weeks ago

lsp-mode does not currently support pull diagnostics.

There is a recent change to the spec where the server can notify the client to request diagnostics, when the pull mode is being used.

This is implemented incorrectly in a number of servers, which do not first check the relevant client capability.

Mitigate this problem by a. Sending client capabilities to day that this is not supported b. Putting a null handler in for the server request message.

Closes #4570

jcs090218 commented 2 weeks ago

Thanks for taking care of this! :D