search

emacs-lsp / lsp-mode

Emacs client/library for the Language Server Protocol
https://emacs-lsp.github.io/lsp-mode
GNU General Public License v3.0
4.81k stars 892 forks source link

Add Nextflow Support #4606

Closed edmundmiller closed 2 weeks ago

edmundmiller commented 3 weeks ago

Adding support for the new Nextflow Language Server.

https://seqera.io/blog/modernizing-nextflow-developer-experience/

Would love some feedback on anything to clean up. It also hangs whenever I try to download the lsp with lsp-install-server

jcs090218 commented 3 weeks ago

Can you update our CHANGELOG? Thanks! :D

edmundmiller commented 2 weeks ago

Done! Thanks @jcs090218!

jcs090218 commented 2 weeks ago

Can you resolve the compile warnings? Thanks! :)

In toplevel form:
lsp-nextflow.el:84:2: Warning: custom-declare-variable `lsp-nextflow-files-exclude' docstring wider than 80 characters
lsp-nextflow.el:100:2: Warning: custom-declare-variable `lsp-nextflow-java-home' docstring wider than 80 characters
edmundmiller commented 2 weeks ago

@jcs090218 Done, thank you!

Lenbok commented 2 weeks ago

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

edmundmiller commented 2 weeks ago

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

I agree, but I think we can address that in a follow-up PR unless you have time to hack that out. I probably won't have time and would like to see this get merged before it gets stale.

jcs090218 commented 2 weeks ago

It would be nice to get the server install working. I had to point the client at the jarfile manually downloaded. Surely since the jarfile is just a download from a GitHub release that should be straight forward? @jcs090218 ?

I agree. It would be nice to have the server installation working, and it's indeed straightforward since I've done it a couple of times myself. :)

I agree, but I think we can address that in a follow-up PR unless you have time to hack that out. I probably won't have time and would like to see this get merged before it gets stale.

No problem! I would like to see smaller PRs since it's usually easier to build progress that way. 🤔

jcs090218 commented 2 weeks ago

Merged! Thank you for your contribution! :D