search

emacs-lsp / lsp-origami

lsp-mode :heart: origami.el
GNU General Public License v3.0
43 stars 6 forks source link

Parser signal interferes with debug-on-error #1

Closed jimmywongroo closed 4 years ago

jimmywongroo commented 5 years ago

There's no need to signal an error when visiting a buffer that does't have lsp mode turned on or support folding. If origami mode is turn on globally, this pops up the debugger every time a new buffer like the above is visited.

https://github.com/emacs-lsp/lsp-origami/blob/c7653602a2f2396b1a42d6053fd2be55fce8e0a2/lsp-origami.el#L55

yyoncho commented 5 years ago

@vibhavp we should enable the origami lsp provider only for lsp-mode buffers that have foldingRangeProvider.