emacs-lsp / lsp-pyright

lsp-mode :heart: pyright
https://emacs-lsp.github.io/lsp-pyright
GNU General Public License v3.0
291 stars 25 forks source link

lsp-goto-implementation not working #60

Closed spookylukey closed 3 years ago

spookylukey commented 3 years ago

Attempting to do lsp-goto-implementation I get this:

lsp--send-request-async: The connected server(s) does not support method textDocument/implementation.
To find out what capabilities support your server use ‘M-x lsp-describe-session’
and expand the capabilities section

That shows:

[-] /home/luke/devel/clients/MAT/rpr
 `-[-] pyright:192087
    |-[-] Buffers
    |  `-[X] models.py
    `-[-] Capabilities
       |-[X] callHierarchyProvider: t
       |-[-] executeCommandProvider:
       |  |-[X] workDoneProgress: t
       |  `-[X] commands: []
       |-[-] codeActionProvider:
       |  |-[X] workDoneProgress: t
       |  `-[X] codeActionKinds: [quickfix source.organizeImports]
       |-[-] signatureHelpProvider:
       |  |-[X] workDoneProgress: t
       |  `-[X] triggerCharacters: [( , )]
       |-[-] completionProvider:
       |  |-[X] workDoneProgress: t
       |  |-[X] resolveProvider: t
       |  `-[X] triggerCharacters: [. []
       |-[-] renameProvider:
       |  `-[X] workDoneProgress: t
       |-[-] documentHighlightProvider:
       |  `-[X] workDoneProgress: t
       |-[-] hoverProvider:
       |  `-[X] workDoneProgress: t
       |-[-] workspaceSymbolProvider:
       |  `-[X] workDoneProgress: t
       |-[-] documentSymbolProvider:
       |  `-[X] workDoneProgress: t
       |-[-] referencesProvider:
       |  `-[X] workDoneProgress: t
       |-[-] declarationProvider:
       |  `-[X] workDoneProgress: t
       |-[-] definitionProvider:
       |  `-[X] workDoneProgress: t
       `-[X] textDocumentSync: 2

Is it indeed the case that this is not supported yet? If it is, is there any guidance on what I might be doing wrong? In VSCode, the pyright extension says it supports: "Find Definitions to quickly go to the location of a symbol’s definition" so I thought this feature would be present.

seagle0128 commented 3 years ago

I think you need lsp-find-definition while not lsp-goto-implementation.

gopls doesn't support method textDocument/implementation.

spookylukey commented 3 years ago

Thanks so much, don't know how I didn't find that. Sorry for the noise!