Rename Symbol not working with lsp-pyright

emacs-lsp / lsp-pyright

lsp-mode :heart: pyright

https://emacs-lsp.github.io/lsp-pyright

GNU General Public License v3.0

291 stars 25 forks source link

Rename Symbol not working with lsp-pyright #64

Open CsBigDataHub opened 3 years ago

CsBigDataHub commented 3 years ago

Not sure if this is a language server issue or lsp-pyright issue.

lsp-rename works with pylsp language server but not pyright

pyright version 1.1.187 lsp-mode 20211115.807

update - tested it with eglot aswell but I had the same issue there, eglot think the rename is successful but it was not.

holocronweaver commented 1 year ago

Are you trying to rename a file or a class/variable/function/etc. in Python code?

lsp-rename for Python code works for me, but I get an error "The connected server(s) doesn't support renaming" when calling lsp-rename on a file in dired.