emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
396 stars 46 forks source link

Avoid positional arguments to define-minor-mode #105

Closed tarsius closed 3 years ago

tarsius commented 3 years ago

Back in Emacs-21.1, define-minor-mode grew keyword arguments to replace its old positional arguments. Starting with Emacs-28.1 warning will be omitted if positional arguments are still used.

Using nil as explicit dummy values for the optional arguments and then subsequently using the corresponding keyword arguments to set the proper was never necessary and also didn't make much sense.

yyoncho commented 3 years ago

Thank you!