emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
393 stars 46 forks source link

Give all minor modes docstrings #129

Closed jhenahan closed 2 years ago

jhenahan commented 2 years ago

Presently, on bleeding edge Emacs, define-minor-mode with an empty docstring makes the mode impossible to load as "" is coerced to nil and subsequently inserted, which is not kosher. The options as they stand are either a non-empty string (as I've done in this patch) or nil, which results in the fallback value of Toggle <mode> on or off. I'm not picky either way. I also sent a bug report to the Emacs list here so this edge case will hopefully be covered (or explicitly disallowed) in the future.

jcs090218 commented 2 years ago

Thanks!