search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
403 stars 48 forks source link

Icons of the LSP symbols are not being shown #159

Closed samebchase closed 1 year ago

samebchase commented 1 year ago

Hi,

I love the symbols list. It's helping me a lot while reading and writing code.

It seems this change, https://github.com/emacs-lsp/lsp-treemacs/commit/323b4c9790f8f48c6dbce65d31dd969d1f55df49 introduces the issue. When I changed -if-let back to if-let the icons are visible again.

Screenshot from 2023-06-30 15-35-41

samebchase commented 1 year ago

Submitted a PR for this: https://github.com/emacs-lsp/lsp-treemacs/pull/160

Thanks once again, for all your efforts! :pray:

pobermei commented 1 year ago

Submitted a PR for this: #160

Thanks once again, for all your efforts! 🙏

@samebchase It appears that #160 is erroneously removing unneeded parentheses from the incorrect line 236, rather than from line 89 as you pointed out above.

samebchase commented 1 year ago

@pobermei My bad, that's a great catch! Let me fix it and send a new PR.

samebchase commented 1 year ago

Raised a new PR https://github.com/emacs-lsp/lsp-treemacs/pull/161