search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
400 stars 47 forks source link

Improve theme #18

Open seagle0128 opened 4 years ago

seagle0128 commented 4 years ago

  1. collapsed and expanded icons are not used. The unicode chars are hard-coded.

  2. Support all-the-icons. The images are not displayed correctly on my MacBook. They look too big as the same as in treemacs. I made a new theme in https://github.com/seagle0128/.emacs.d/blob/master/lisp/init-lsp.el#L157, which is similar in doom-themes-ext-treemacs.

image

yyoncho commented 4 years ago

collapsed and expanded icons are not used. The unicode chars are hard-coded.

The issue with expanded/collapsed icons is that there are theme-specific - they have a dark theme and white theme so I decided to use the ascii chars. I will make them configurable though.

As for the all-the-icons theme. I wonder whether is should go in each repo(e. g. in lsp-java/dap-mode/lsp-treemacs/treemacs) or we should have a separate package that defines all the icons theme for all packages. WDYT?

seagle0128 commented 4 years ago

The issue with expanded/collapsed icons is that there are theme-specific - they have a dark theme and white theme so I decided to use the ascii chars. I will make them configurable though.

You can see what I've done in doom-themes-ext-treemacs. chevron-down and chevron-right are used for expanded/clooapsed. font-lock-doc-face should be good for both dark and light themes.

As for the all-the-icons theme. I wonder whether is should go in each repo(e. g. in lsp-java/dap-mode/lsp-treemacs/treemacs) or we should have a separate package that defines all the icons theme for all packages. WDYT?

A separate package is fine but not necessary. We do this check in doom-themes, and make all-the-icons optional.

(unless (require 'all-the-icons nil t)
    (error "all-the-icons isn't installed"))

BTW, if the unicode chars are not available, what are the fallbacks?