emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
398 stars 47 forks source link

Mode line improvements #29

Closed danielmartin closed 4 years ago

danielmartin commented 4 years ago

With some standard mode lines, lsp-treemacs always shows "Treemacs" in the mode line, making panes difficult to distinguish.

This PR solves the problem by setting either of these two buffer local variables:

I think this PR supersedes https://github.com/emacs-lsp/lsp-treemacs/pull/10, so I've removed the major modes that that PR created.

danielmartin commented 4 years ago

@yyoncho What we discussed in Gitter. I've tested with a standard mode line and a Doom mode line and this approach seems to work as expected. It wouldn't be a bad idea to test this with Spacemacs mode line as well.

yyoncho commented 4 years ago

Looks good! We should do the same for dap-mode as well. I tested with spaceline and it works fine.