search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
398 stars 47 forks source link

Please consider making a melpa-stable release compatible with lsp-mode 6.3.1 #49

Closed laurynas-biveinis closed 4 years ago

laurynas-biveinis commented 4 years ago

The latest lsp-treemacs commits seem to break compatibility with lsp-mode 6.3.1 version: https://github.com/emacs-lsp/lsp-treemacs/commit/bf054531c278c5d41de504bec3c3df3f2e76c132 https://github.com/emacs-lsp/lsp-treemacs/commit/90754e4189fc78be31f338383db3d8a2042fd8bc

I am only a light lsp-treemacs user so I did not notice the above immediately, but then came along https://github.com/emacs-lsp/lsp-treemacs/commit/5d3f7b49a14b1dd7457c4dcf4233be83b6a4d637, at which point package load broke, presumably due to lsp-defun being unavailable.

Maybe tagging last-compatible-with-6.3.1 commit to melpa-stable would be a good idea?

Thanks,

yyoncho commented 4 years ago

I tagged https://github.com/emacs-lsp/lsp-treemacs/releases/tag/0.1 (not sure I have picked the correct version).

laurynas-biveinis commented 4 years ago

Works in my testing, thank you!