search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
396 stars 46 forks source link

Include symbol name when detailed-outline is enabled #76

Closed jakejx closed 3 years ago

jakejx commented 3 years ago

After 1dbc202fe61b48c94ed872df80403456f51bf46c, when lsp-treemacs-detailed-outline is t, the name of the symbol is not included in the tree and only the detail is rendered. This is a small fix to include the name. Based on the spec, detail only includes additional information, so the name should always be rendered

nbfalcon commented 3 years ago

We should use lsp-render-symbol instead (so this should be closed), see this PR #73. This was the intended use case for that function. Here is how it would look with my PR instead: 20201111-163412 You can customize lsp-signature-face to change the look of the signature. The point is that we don't duplicate the same symbol rendering code everywhere, with differing feature levels (deprecated highlighting, signature display) in various parts of lsp-mode.

yyoncho commented 3 years ago

Thank you for the PR but I am closing it in favour of #73