lsp-treemacs--project-diagnostics: prefer nconc

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs

GNU General Public License v3.0

396 stars 46 forks source link

lsp-treemacs--project-diagnostics: prefer nconc #78

Closed leungbk closed 3 years ago

leungbk commented 3 years ago

yyoncho commented 3 years ago

I am merging this but all this should be rewritten either way...

yyoncho commented 3 years ago

I reverted this PR. Users are complaining that lsp-treemacs-errors-list is blocking and this seems to be the only PR that might cause that. I think that nconc could cause that if you create a loop in in the list.

nbfalcon commented 3 years ago

This PR makes the modified function non-side-effect-free, because it alters the mapped to FILE-DIAGS.