search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
396 stars 46 forks source link

Fix goto defintion #93

Closed nbfalcon closed 3 years ago

nbfalcon commented 3 years ago

Since lsp-treemacs-perform-ret-action no longer passes the node to :ret-action, an error is thrown when pressing RET on a symbol.

Fix that by having lsp-treemcas-symbols-goto-symbol take &rest and to always use the node at point.

Sorry, it seems I haven't tested my PR thoroughly enough...

yyoncho commented 3 years ago

In general it should be implemented using lsp-treemacs-define-action

nbfalcon commented 3 years ago

That macro is unused?

yyoncho commented 3 years ago

https://github.com/search?q=org%3Aemacs-lsp+lsp-treemacs-define-action&type=code

And it is the same as dap-ui-define-action

nbfalcon commented 3 years ago

I'll do that now. It will need some improvements though: docstring support, and the declare specs are off by one.