search

emacs-lsp / lsp-treemacs

lsp-mode :heart: treemacs
GNU General Public License v3.0
396 stars 46 forks source link

CI Implementation #97

Closed jcs090218 closed 3 years ago

jcs090218 commented 3 years ago

All check have passed, See https://github.com/jcs-PR/lsp-treemacs/actions/runs/522849071.

Not sure if we either have to merge this to active GitHub Actions or this feature is disable by default in this repository.

jcs090218 commented 3 years ago

Okay, I am getting these warnings after enabled byte-compile-error-on-warn.

In toplevel form:
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `start'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `uri'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `detail\?'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `name'

Any idea?

yyoncho commented 3 years ago

Okay, I am getting these warnings after enabled byte-compile-error-on-warn.

In toplevel form:
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `start'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `uri'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `detail\?'
lsp-treemacs.el:1211:1: Warning: Unused lexical variable `name'

Any idea?

Most likely these variables must be fixed.

jcs090218 commented 3 years ago

Most likely these variables must be fixed.

Yeah, I am not very familiar with the code here. Do you know how to fix these warnings?

jcs090218 commented 3 years ago

Fixed by this commit, https://github.com/emacs-lsp/lsp-treemacs/pull/97/commits/4010ac36e3da3bcaa2d997e1f7095b6827e64f3b.

All CI have passed! 🎉 See https://github.com/jcs-PR/lsp-treemacs/actions/runs/523185742.

yyoncho commented 3 years ago

Can you resolve the conflicts?

jcs090218 commented 3 years ago

Resolved!

yyoncho commented 3 years ago

Resolved!

Thank you, sorry for causing the merge conflict, I forgot about this PR.