search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.04k stars 141 forks source link

Actions must be updated when selection changes #110

Open yyoncho opened 6 years ago

yyoncho commented 6 years ago

Some of the actions depend on selection(e. g. extract method) so they must be updated when selections changes.

yyoncho commented 6 years ago

@sebastiencs there is a check in lsp-ui-sideline--stop-p in which the sideline is not updated when there is an active region. As a result, LSP UI does not display actions which act on selected region(e. g. Extract method). When I commented this line everything seems to work.

Can you share your thoughts?

sebastiencs commented 6 years ago

I've set this condition because the informations on the sideline are conflicting with the region background color: region Do you want to display only actions when the region is active or the hover informations too ?

yyoncho commented 6 years ago

My main concern is that actions that require selection are not displayed(losing functionality). As for hover info we might hide it/display information only for the region/leave it as it is, it is not a major issue for me. If you don't have a time to work on the issue, can you share your thoughs what the proper fix must be as assign the issue to me.