search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.04k stars 141 forks source link

Provide faces for error/warning/success #118

Closed Fuco1 closed 6 years ago

Fuco1 commented 6 years ago

Provide faces lsp-ui-flycheck-error etc that inherit from the built-in faces. This allows users to customize the faces used by this mode but keep the globals as they are. By inheriting by default this change will have no effect on any existing user.

For example I would like to add a black background color because the lines are not very visible in my theme, but I don't want to change the overall value of error face (and friends).

Fuco1 commented 6 years ago

This should also be handled in lsp-ui-sideline--flycheck where the errors are being shown, the face is computed again there.

sebastiencs commented 6 years ago

@Fuco1 Do you mean faces that would be used in lsp-ui-flycheck-list ? Or faces to highlight diagnostics in the current buffer ?

If it is for faces that flycheck is using to highlight diagnostics in the current buffer, lsp-ui-flycheck has no control on them.

Fuco1 commented 6 years ago

I mean the faces used to draw the "boxes" with errors. I'm not really sure which component of lsp-ui does that.

The red-on-black box here.

Fuco1 commented 6 years ago

I have since found lsp-ui-sideline-global to add the black background there, so I think this can be closed. I'm actually not sure what I ment in the OP :D Ah well.