search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

fci-mode breaks lsp-ui-sideline #339

Open SreenivasVRao opened 4 years ago

SreenivasVRao commented 4 years ago

hi, thanks a lot for lsp-ui. I think it's a really great package, and I'm very happy with it so far. I recently found this bug, and I'm just passing along the info:

https://gfycat.com/likablerealisticgrackle -> as you can see, the lines jump when lsp-ui shows up. The behaviour is caused due to some funny business with fci-mode being active. When I disable fci-mode, that line jumping goes away.

My workaround right now is to disable fci-mode.

danielmartin commented 4 years ago

Thanks for the report. I've added the "bug" label. fci-mode is a package with some known incompatibilities, and the functionality of fci-mode will be provided natively in Emacs 27 (display-fill-column-indicator-mode).

It'd be interesting to test if display-fill-column-indicator-mode from Emacs master exhibits the same behavior.

joncol commented 4 years ago

FYI, it seems that changing to display-fill-column-indicator-mode indeed solves this issue.