search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.04k stars 139 forks source link

Add posframe integration to lsp-ui-doc #480

Open ericdallo opened 4 years ago

ericdallo commented 4 years ago

Another try to https://github.com/emacs-lsp/lsp-ui/pull/459 which was reverted

lsp-ui-doc-posframe

ericdallo commented 4 years ago

@Sorixelle created this PR trying to fix some issues, we should merge that when we confirm that the issues reported before are fixed. It works ok for my NixOS - bspwm window manager. We should try with xmonad users and macos users who reported issues with mouse hover.

brotzeit commented 4 years ago

Merge ?

yyoncho commented 4 years ago

I think that all that complained in #465 should test that.

(@seagle0128 was one of them)

ericdallo commented 4 years ago

Yes, I tested it on NixOS (bspwm window manager), but it would be better to test on macOS and gnome that had issues.

yyoncho commented 4 years ago

It works fine on gnome2.

seagle0128 commented 4 years ago

I tested on macOS. It's not working well. The screenshot is below.

image

The original is image

kiennq commented 4 years ago

Can this one be merged yet?

ericdallo commented 4 years ago

We need to fix @seagle0128 bug or ask for more people to test it, I think