emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.04k stars 139 forks source link

[lsp-ui-sideline] Sideline msg breaks indentation using indent-guide-mode #520

Closed chama-chomo closed 3 years ago

chama-chomo commented 3 years ago

In certain cases, LSP sideline (linting) msg causes the actual code block to get prepended with an empty line.

e.g. initial state: image

broken state (cursor moved one line to the bottom): image

System Info

chama-chomo commented 3 years ago

my lsp configuration:

(lsp :variables
          lsp-server-trace nil
          lsp-log-io nil
          lsp-ui-doc-position 'top
          lsp-ui-doc-enable t
          lsp-ui-doc-header nil
          lsp-ui-doc-include-signature nil
          lsp-ui-doc-max-width 120
          lsp-ui-doc-max-height 40
          lsp-ui-doc-use-childframe t
          lsp-ui-doc-use-webkit t
          lsp-ui-peek-enable t
          lsp-ui-peek-peek-height 10
          lsp-ui-peek-list-width 50
          lsp-cache-candidates t
          ;; lsp-ui-sideline
          lsp-ui-sideline t
          lsp-ui-sideline-enable t
          lsp-ui-sideline-ignore-duplicate t
          lsp-ui-sideline-show-symbol t
          lsp-ui-sideline-show-hover nil
          lsp-ui-sideline-show-diagnostics t
          lsp-ui-sideline-show-code-actions t
          lsp-ui-sideline-code-actions-prefix ""
          lsp-signature-doc-lines 2
          lsp-signature-render-documentation nil
          lsp-signature-auto-activate nil
          )
yyoncho commented 3 years ago

This is with indent-guide on, right?

chama-chomo commented 3 years ago

This is with indent-guide on, right? Yes, guide on. You can see those grey pipes on the left, where one of them is out of the position.

sebastiencs commented 3 years ago

@chama-chomo Should be fixed with https://github.com/emacs-lsp/lsp-ui/commit/25552041f5af110c282fe8a2c714dec0f7a2320e

chama-chomo commented 3 years ago

Thanks! looking forward to testing it.

chama-chomo commented 3 years ago

I can confirm the new version of lsp-ui fixes this problem.