search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 139 forks source link

Zoom-mode doesn't resize windows with LSP-UI enabled. #537

Open smsegal opened 3 years ago

smsegal commented 3 years ago

When trying to use zoom-mode to automatically resize windows, any LSP managed buffers don't resize on switching into and out of the window as expected.

Instead, the window only resizes after a key is pressed that will incidentally resize the window. In my case, as soon as which-key is invoked the zoom window resizing will take place.

This has occurred when using lsp servers for python, LaTeX, and javascript. I've tested with lsp and lsp-deferred as hooks and the issue is the same. As soon as I disable lsp-mode in the buffer then zoom-mode works as advertised.

To Reproduce

  1. Have at least one lsp-managed window open with lsp-ui enabled, as well as some standard buffers.
  2. Enable zoom-mode
  3. Observe that windows that aren't using lsp-ui mode resize automatically when entered or exited.

Expected behavior The expected behaviour is for the windows to automatically resize and reflow according to the window ratios specified in zoom-mode upon entering and exiting the window.

OS Fedora 33

jcs090218 commented 3 years ago

Hmmm... I never use [zoom-mode]() but I'm assuming this is the bug that conflict to another package?

The expected behaviour is for the windows to automatically resize and reflow according to the window ratios specified in zoom-mode upon entering and exiting the window.

Do you know what specific lsp-ui is causing this issue? Maybe the ui-doc, ui-imenu, etc?

Thanks for reporting this issue to us! 👍

smsegal commented 3 years ago

Just did some quick testing. It appears that as soon as ui-doc is disabled, zoom mode works properly again. I disabled ui-doc with (setq lsp-ui-doc-enable nil), restarted emacs and the problem went away.

jcs090218 commented 3 years ago

Just did some quick testing. It appears that as soon as ui-doc is disabled, zoom mode works properly again. I disabled ui-doc with (setq lsp-ui-doc-enable nil), restarted emacs and the problem went away.

Thank you! This is definitely the first step that help us knowing the issue! ;)

Mark with label ui-doc for now.