Closed JohnC32 closed 3 years ago
LGTM, would you mind showing the before/after comparison screenshot? I just want to have a look so it's easier for everyone to see instead of the code! Thank you! ;)
For lsp-ui-peek-highlight, here's the setup prior to my proposal
and the proposal (notice the red box lets you see which getName is the reference on the line in addition to the highlighted symbol in yellow):
For lsp-ui-sideline-current-symbol, here's the setup prior to my proposal (notice the "[name]" below the square in the box on the right is invisible because it's white on white):
and the proposal (notice the "[name]" below the square in the box is now black on white):
For lsp-ui-sideline-code-action, notice the "fix-it" code action is hard to read because it's yellow on white:
and the proposal (notice that you can now read the fix-it code action because it's dark orange on white):
Thanks John
LGTM, Thanks!
lsp-ui-peek-highlight had handling for light background but dim gray is too light. Also can we add a red box as this looks good.
lsp-ui-sideline-current-symbol had handling for light backgrounds, but order was wrong, also dim gray and the light background are too close, thus proposed a more visible colors
lsp-ui-sideline-code-action had handling for light backgrounds, but order was wrong, fixed.