emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 139 forks source link

Update a couple faces to look good on light background's #539

Closed JohnC32 closed 3 years ago

JohnC32 commented 3 years ago
jcs090218 commented 3 years ago

LGTM, would you mind showing the before/after comparison screenshot? I just want to have a look so it's easier for everyone to see instead of the code! Thank you! ;)

JohnC32 commented 3 years ago

For lsp-ui-peek-highlight, here's the setup prior to my proposal

lsp-ui-peek-highlight-orig

and the proposal (notice the red box lets you see which getName is the reference on the line in addition to the highlighted symbol in yellow):

lsp-ui-peek-highlight-new

For lsp-ui-sideline-current-symbol, here's the setup prior to my proposal (notice the "[name]" below the square in the box on the right is invisible because it's white on white):

lsp-ui-sideline-current-symbol-old

and the proposal (notice the "[name]" below the square in the box is now black on white):

lsp-ui-sideline-current-symbol-new

For lsp-ui-sideline-code-action, notice the "fix-it" code action is hard to read because it's yellow on white:

lsp-ui-sideline-code-action-orig

and the proposal (notice that you can now read the fix-it code action because it's dark orange on white):

lsp-ui-sideline-code-action-new

Thanks John

jcs090218 commented 3 years ago

LGTM, Thanks!