search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 139 forks source link

Size of lightbulb.png is too big 128x128px. #570

Closed segitwo closed 3 years ago

ericdallo commented 3 years ago

Yeah, the ideal sould be to replace it with a .svg, not sure emacs supports svg though

sebastiencs commented 3 years ago

What is the issue with that size ? The image is resized (to make it smaller) and visually it should fits in the line.

By using a smaller size, the image would have to be resized too, but by making it bigger and it would appear pixelated.

Yeah, the ideal sould be to replace it with a .svg, not sure emacs supports svg though

Emacs does support svg images, but it requires a compile time flag, and not all linux distribution package Emacs with that flag

shadyalfred commented 3 years ago

image

When I hover over lines with errors or warnings, the height of the lines increases, then when I move away it decreases. It is kinda annoying seeing the lines glitching like this.

hammerandtongs commented 3 years ago

This is pretty painful as is.

The lightbulb is about 5 lines tall and it causes the text to jump around it as i scroll along.

Is there a simple way to disable the lightbulb for now?

sebastiencs commented 3 years ago

@ShadyAlfred @hammerandtongs Can you please post the value of those 3 variables: system-configuration, system-configuration-options and system-configuration-features

You can disable it with (setq lsp-ui-sideline-actions-icon nil)

shadyalfred commented 3 years ago

system-configuration image

system-configuration-options image

system-configuration-features image

hammerandtongs commented 3 years ago

"x86_64-pc-linux-gnu"

"--build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.3/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --build x86_64-linux-gnu --prefix=/usr --sharedstatedir=/var/lib --libexecdir=/usr/lib --localstatedir=/var/lib --infodir=/usr/share/info --mandir=/usr/share/man --enable-libsystemd --with-pop=yes --enable-locallisppath=/etc/emacs:/usr/local/share/emacs/26.3/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/26.3/site-lisp:/usr/share/emacs/site-lisp --with-sound=alsa --without-gconf --with-mailutils --with-x=yes --with-x-toolkit=gtk3 --with-toolkit-scroll-bars 'CFLAGS=-g -O2 -fdebug-prefix-map=/build/emacs-mEZBk7/emacs-26.3+1=. -fstack-protector-strong -Wformat -Werror=format-security -Wall' 'CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2' 'LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro'"

"XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD LCMS2"

padraic00 commented 3 years ago

Any updates on this?

yyoncho commented 3 years ago

@jcs090218 is this fixed with https://github.com/emacs-lsp/lsp-ui/commit/63533f120ade4af71d0744ae7bd208e1b9420a1f ?

jcs090218 commented 3 years ago

@jcs090218 is this fixed with 63533f1 ?

@yyoncho I did fix the glitch.

But since there is no description from the author so I don't know if I should close this issue.

@padraic00 Can you update to the latest version and see does the commit 63533f120ade4af71d0744ae7bd208e1b9420a1f suit your needs? Thanks!

padraic00 commented 3 years ago

@padraic00 Can you update to the latest version and see does the commit 63533f1 suit your needs? Thanks!

currently on 78e0a41. Still unfixed.

System Info :computer:

ericdallo commented 3 years ago

Alright, @yyoncho @jcs090218 since the issue is not solved, can we disable that icon by default and re-enable it when fixed? We already have #573 and https://github.com/emacs-lsp/lsp-mode/issues/2628, so it seems to affect multiple users

jcs090218 commented 3 years ago

Let's move this issue to #573 since I think it has a better bug report. :)

Close this issue now.