Simplify margin logic and fix wrong alignment

emacs-lsp / lsp-ui

UI integrations for lsp-mode

https://emacs-lsp.github.io/lsp-ui

GNU General Public License v3.0

1.03k stars 141 forks source link

Simplify margin logic and fix wrong alignment #595

Closed jcs090218 closed 3 years ago

jcs090218 commented 3 years ago

Calculation of line-number-display-width should be calculated inside lsp-ui-sideline--margin-width and we should not apply margin to the calculation while displaying sidelines.

This also fixes #594.

XO39 commented 3 years ago

This totally broke the sideline and made it unusable for me, I had to downgrade to #592. I hope it gets fixed soon.

jcs090218 commented 3 years ago

@XO39 Can you tell me what's broken? And what Emacs version you are using? Thanks!

Yevgnen commented 3 years ago

Same here. Almost unusable when typing because the line is moving up and down.

lsp-ui version: master
emacs version: GNU Emacs 27.1.91 (build 2, x86_64-apple-darwin20.2.0, Carbon Version 164 AppKit 2022.2) of 2021-03-13