emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

lsp-ui-doc : `q` closes the window AND types "q" #608

Open Trevoke opened 3 years ago

Trevoke commented 3 years ago

This is probably just something dumb I'm doing but when the doc window opens and I hit "q", it does close the doc window... But it also types "q" in the buffer, which isn't something I desire.

Is there a way for me to only close the doc pop-up?

yyoncho commented 3 years ago

q is just q and the window is closed because the buffer has changed. It will close on any char. There is lsp-ui-doc-hide which you can use to hide the doc window.

Trevoke commented 3 years ago

Ah, OK!

What's lsp-ui-doc-frame-mode-map ?

yyoncho commented 3 years ago

https://www.gnu.org/software/emacs/manual/html_node/elisp/Keymap-Basics.html

Trevoke commented 3 years ago

No... I mean... What is it for ? Based on the name I thought it might be for the documentation pop-up but obviously not (it is where I got q from)

yyoncho commented 3 years ago

I don't understand the question. This object is keymap and it is used to bind keys in the posframe window.

Trevoke commented 3 years ago

Okay now I just have to figure out what the postframe window was.

How many of these questions that I am asking should be answered in the README, by the way?

yyoncho commented 3 years ago

Okay now I just have to figure out what the postframe window was.

The posframe is the popup window.

How many of these questions that I am asking should be answered in the README, by the way?

Definition of what keymap is in emacs docs. The same is true for posframe.

Trevoke commented 3 years ago

Okay, so ... How come the button "q" in the postframe window keymap isn't attached to lsp-ui-doc-hide ?

On Wed, May 5, 2021 at 4:31 PM Ivan Yonchovski @.***> wrote:

Okay now I just have to figure out what the postframe window was.

The posframe is the popup window.

How many of these questions that I am asking should be answered in the README, by the way?

Definition of what keymap is in emacs docs. The same is true for posframe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emacs-lsp/lsp-ui/issues/608#issuecomment-832986856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAQSSMREWJYA22DYGSM3P3TMGTJHANCNFSM44FSMIDQ .