[lsp-ui-doc] Add option to disable markdown formatting

emacs-lsp / lsp-ui

UI integrations for lsp-mode

https://emacs-lsp.github.io/lsp-ui

GNU General Public License v3.0

1.03k stars 141 forks source link

[lsp-ui-doc] Add option to disable markdown formatting #612

Closed sebastiencs closed 2 years ago

sebastiencs commented 3 years ago

Attempt to address #611

anonimitoraf commented 2 years ago

Hi guys, anything stopping this branch from being merged to master?

jcs090218 commented 2 years ago

The code looks good to me! Does these changes resolved the issue for you?

anonimitoraf commented 2 years ago

Hmm I still see the overflow described in https://github.com/emacs-lsp/lsp-ui/issues/611

I did notice that this only happens when lsp-ui-doc-use-childframe is set to t. If set to nil it seems fine (but other problems: can't scroll down)

ericdallo commented 2 years ago

Merging this as it seems to improve current behavior