search

emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.04k stars 140 forks source link

Fix #615: Display the border color of the child frame. #616

Closed seagle0128 closed 3 years ago

seagle0128 commented 3 years ago

Fix #615 .

See https://github.com/tumashu/posframe/blob/739d8fd1081bdd0d20dee9e437d64df58747b871/posframe.el#L355-L356.

seagle0128 commented 3 years ago

I tested on macOS Big Sur, with GNU Emacs 28.0.50 (--with-native-compilation).

Before: image

After: image

seagle0128 commented 3 years ago

The CI seems failed due to the env issue. @ericdallo Can you please rerun the cases and merge the PR?

jcs090218 commented 3 years ago

Thanks for the fix!

CsBigDataHub commented 3 years ago

@seagle0128 This PR works fine on Emacs 28, but it does not display border on Emacs 27. Is there a work around to get it working on Emacs27?

Thanks

seagle0128 commented 3 years ago

@CsBigDataHub I think it's an issue of Emacs 27.

CsBigDataHub commented 3 years ago

@seagle0128 I think this a issue on MacOs builds, I can see borders on Ubuntu KellyK emacs 27.

seagle0128 commented 3 years ago

Yes. It's an issue of Emacs 27 on macOS.