emacs-lsp / lsp-ui

UI integrations for lsp-mode
https://emacs-lsp.github.io/lsp-ui
GNU General Public License v3.0
1.03k stars 141 forks source link

sideline moves the cursor #650

Open djarb opened 2 years ago

djarb commented 2 years ago

When navigating through the code using page up/page down, sideline tries to get relevant information from the LSP server for whatever point the cursor happens to be at, and then jumps the cursor back to that point after the LSP server responds. That's remarkably annoying.

Moving the cursor ought to cancel any in-progress actions by sideline.

jcs090218 commented 2 years ago

Thanks for reporting this issue to us!

I notice this issue a while ago but have not got into time to investigate and reproduce it. Can you describe how you reproduce this issue? So I can apply a fix for it!

djarb commented 2 years ago

I'm use the rust-analyzer LSP server, sideline with the code actions shown in the sideline, source files long enough to require several page up operations to go from the bottom to the top, and I've got lsp-ui-sideline-delay set to two seconds. If I go to the bottom of the source file and hit the page up key repeatedly, the problem always occurs.

On Wed, Sep 8, 2021 at 7:51 AM Jen-Chieh Shen @.***> wrote:

Thanks for reporting this issue to us!

I notice this issue a while ago but have not got into time to investigate and reproduce it. Can you describe how you reproduce this issue? So I can apply a fix for it!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/emacs-lsp/lsp-ui/issues/650#issuecomment-915308660, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABE2IYRXLSVRYOFMXIJQWDUA5Z67ANCNFSM5DULC6RA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.