Organize, clean up, and improve performance

emacs-lsp / lsp-ui

UI integrations for lsp-mode

https://emacs-lsp.github.io/lsp-ui

GNU General Public License v3.0

1.03k stars 141 forks source link

Organize, clean up, and improve performance #674

Closed jcs090218 closed 2 years ago

jcs090218 commented 2 years ago

This patch does the following,

Move lsp-ui-util to lsp-ui
Clean up some code
Improve performance with macro lsp-ui--with-no-redisplay

ericdallo commented 2 years ago

@jcs090218 just curious, how much performance does this PR improve?

jcs090218 commented 2 years ago

@ericdallo I'm still playing around and hope the user experience can be snappier. I am pretty much wrapping all inhibit-redisplay, buffer-list-update-hook, etc with new macro lsp-ui--with-no-redisplay. I have done something similar to elp-revive/company-box (my fork), and it got faster without changing the outcome.

I don't know how much the performance will be improved, but I guess it's a good start?