When use company with lsp, flycheck make the first(default selected) cadicate invisible.

zw963 commented 2 years ago

Thank you for the bug report

[X] I am using the latest version of lsp-mode related packages.
[X] I checked FAQ and Troubleshooting sections
[X] You may also try reproduce the issue using clean environment using the following command: M-x lsp-start-plain

Which Language Server did you use?

lsp-dart

OS

Linux

Error callstack

No

Anything else?

No

yyoncho commented 2 years ago

Please provide detailed steps to reproduce.

zw963 commented 2 years ago

Please provide detailed steps to reproduce.

Okay, finally, i find out what cause this issue.

Following is a can reproducable config:

(setq truncate-partial-width-windows t)
(require 'flycheck_init)
(require 'company)
(setq company-show-quick-access t)
(require 'treemacs)

(require 'dap-mode)
(require 'dap-ui)
(require 'dap-mouse)

(require 'lsp-mode)
(require 'lsp-modeline)
(require 'lsp-headerline)
(require 'lsp-diagnostics)

(require 'lsp-ui)
(setq lsp-ui-sideline-show-code-actions t)

(require 'lsp-dart)
(require 'dart-mode)
(add-hook 'dart-mode-hook 'lsp)
(add-to-list 'auto-mode-alist '("\\.dart\\'" . dart-mode))
(with-eval-after-load 'treemacs
  (add-hook
   'dart-mode-hook
   (lambda ()
     (save-selected-window (treemacs-select-window))))
  )

This issue only happen when company candidate occur at first, then the code action appear, which broken the company candidate menu, create blank line onto it.

If not set truncate-partial-width-windows to t, we can see the blank line added into company candidate menu. like this:

For reproduce the exact the issue i meet, following condition must meet:

(setq lsp-ui-sideline-show-code-actions t), which can make above blank line reproduceable.
(setq truncate-partial-width-windows t), and ensure to open treemacs when try to reproduce this issue.

Then, you will see there exists cases which the first candidate invisible.

it sound like treemacs exists some issue ... but anyway, report here for check it out.

yyoncho commented 2 years ago

moving the issue in lsp-ui. as a side note, using company-posframe will fix the issue.

zw963 commented 2 years ago

Yes, i confirm, company-posframe work quite well.

emacs-lsp / lsp-ui